stdenv setup: Run setup hooks and other processing after accumulating deps #31723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deps I find the separation of concerns, accumulating, then processing, easier to follow. Also, with my yet-to-be-merged cross work, the accumulation part will become more complex.
|
@nixborg build |
|
Jobset created at https://hydra.mayflower.de/jobset/nixos/pr-31723 |
orivej
approved these changes
Nov 16, 2017
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Dependencies are now just accumulated in
findInputs, and and their setup hooks and other side-effectual stuff run after. Some packages, along with work by @sjmackenzie IIRC, usedfindInputsseparately. I'm a bit dubious of this in general, but this makes it better by havingfindInputsjust, you know, find the inputs. In any event, I find the separation of concerns more readable, especially once I complicate the propagation logic in my yet-to-be-merged cross work.This is a part of #31414 that currently actually works, heh.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)