Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmocka: 1.0.1 -> 1.1.1 #31712

Merged
merged 1 commit into from Nov 15, 2017
Merged

cmocka: 1.0.1 -> 1.1.1 #31712

merged 1 commit into from Nov 15, 2017

Conversation

stephengroat
Copy link
Contributor

@stephengroat stephengroat commented Nov 15, 2017 •
edited by c0bw3b

Motivation for this change

package updated

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2017

Thanks for your contribution. Could you please squash your 2 commits into one cmocka: 1.0.1 -> 1.1.1 ?

Have you tested building it?

@stephengroat
Copy link
Contributor Author

no problem, squashed.

i've tested on macOS and ubuntu, not on NixOS

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2017 •
edited

nox-review completed successfully on nixos-17.09

Result in /tmp/nox-review-wb0zx0wn
total 4
lrwxrwxrwx 1 zzzz users 56 15 nov.  22:40 result -> /nix/store/zcf2dwlxbrw4h959j90wazzwz0j40978-autofs-5.1.3
lrwxrwxrwx 1 zzzz users 56 15 nov.  22:40 result-2 -> /nix/store/w9dkdxw4hjpkj7dkci5s0nyl3jakgn89-cmocka-1.1.1
lrwxrwxrwx 1 zzzz users 63 15 nov.  22:40 result-3 -> /nix/store/fpr235lw2bdihsx31adfybz6a79wcqv8-knot-resolver-1.5.0
lrwxrwxrwx 1 zzzz users 55 15 nov.  22:40 result-4 -> /nix/store/rgkif6a8rgcdvvr1543bifkwb0nnykfd-sssd-1.16.0

@stephengroat
Copy link
Contributor Author

@c0bw3b i updated the formula to use the majorVersion, version scheme that i found in https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/gupnp-igd/default.nix

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2017

Ok works for me.

@c0bw3b c0bw3b merged commit 958d603 into NixOS:master Nov 15, 2017
@stephengroat stephengroat deleted the patch-1 branch November 15, 2017 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stephengroat @c0bw3b @GrahamcOfBorg @Janik-Haag