Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovim: ruby and python isolation #31726

Merged
merged 1 commit into from Nov 20, 2017
Merged

neovim: ruby and python isolation #31726

merged 1 commit into from Nov 20, 2017

Conversation

garbas
Copy link
Member

@garbas garbas commented Nov 16, 2017 •
edited

the code has been taken from #31604 and fixed so that :CheckHealth for
ruby provider is also green (ruby and gem are required to be in PATH).

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@garbas
neovim: ruby and python isolation
59631bb 
the code has been taken from NixOS#31604 and fixed so that :CheckHealth for
ruby provider is also green (ruby and gem are required to be in PATH).
@garbas
Copy link
Member Author

garbas commented Nov 16, 2017

@manveru I picked manually the changes from your #31604 PR. Can you check if everything works for you and if :CheckHealth is also green for you.

@manveru
Copy link
Contributor

manveru commented Nov 16, 2017

@garbas all works fine, thanks a lot!

@garbas garbas merged commit fb5f41b into NixOS:master Nov 20, 2017
@garbas garbas deleted the nvim-update branch November 20, 2017 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garbas @manveru @GrahamcOfBorg