Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COPYING: there are no more bootstrap binaries in Nixpkgs tree #31386

Merged
merged 1 commit into from Nov 8, 2017
Merged

COPYING: there are no more bootstrap binaries in Nixpkgs tree #31386

merged 1 commit into from Nov 8, 2017

Conversation

lukateras
Copy link
Member

Motivation for this change

COPYING has path to bash listed as an example that doesn't exist anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 8, 2017

The binaries were deleted in 18d7309, there are no binaries in pkgs/stdenv/linux/bootstrap-files now.

@lukateras
Copy link
Member Author

lukateras commented Nov 8, 2017 •
edited

@orivej Then it makes sense to drop the clause entirely. I've updated the patch.

@lukateras lukateras changed the title COPYING: fix path to bootstrapping tools COPYING: there are no more bootstrap binaries in Nixpkgs tree Nov 8, 2017
@globin globin merged commit 8bc70c8 into NixOS:master Nov 8, 2017
@lukateras lukateras deleted the patch-6 branch December 18, 2017 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukateras @orivej @globin