treewide: get rid of invalid buildPhases argument
#31390
Conversation
|
currently running |
|
I'd prefer removing them, as apparently running the other phases causes no harm and all of these are missing the |
|
makes sense. Should I remove all the usages of the phases argument where possible then? (IIRC many of them skip the fixup phase as well)
… On 8. Nov 2017, at 11:45 AM, Robin Gloster ***@***.***> wrote:
I'd prefer removing them, as apparently running the other phases causes no harm and all of these are missing the fixupPhase which should always be included IMHO
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
It isn't as easy as just removing all phases arguments, some definitely will need |
|
@globin I think I should've been more precisely. You mentioned that the Furthermore I think it might be better if we do this in another PR :-) |
Ma27
force-pushed
the
fix-buildphase-expressions
branch
from
1199f6a
to
c26a27e
Compare
|
currently running |
I don't know where this comes from (I accidentally did that as well once), but some derivations seem to use `buildPhases` rather than `phases` in their derivations. This kills all improper usages as the lack of a `phases` argument didn't break the build, so this can be safely removed.
Ma27
force-pushed
the
fix-buildphase-expressions
branch
from
c26a27e
to
161e80e
Compare
Ma27
changed the title
buildPhases argument
|
|
Motivation for this change
I don't know where this comes from (I accidentally did that as well
once), but some derivations seem to use
buildPhasesrather thanphasesin their derivations.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)