Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builtin shortcodes #2195

Merged
merged 6 commits into from Jan 4, 2016
Merged

Builtin shortcodes #2195

merged 6 commits into from Jan 4, 2016

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Dec 24, 2015

  • Adds nikola/data/shortcodes/templateenginename for "builtin" shortcodes
  • Loads those
  • Adds a raw shortcode
  • Use jinjify to translate shortcodes

@gour gour mentioned this pull request Dec 24, 2015
Closed
11 tasks
Kwpolska
Kwpolska reviewed Dec 26, 2015
View reviewed changes
nikola/nikola.py
with open(os.path.join(sc_dir, fname)) as fd:
template_data = fd.read()

def render_shortcode(t_data=template_data, **kw):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be better with functools.partial?

@Kwpolska
Copy link
Member

👍

ralsina added a commit that referenced this pull request Jan 4, 2016
@ralsina
Merge pull request #2195 from getnikola/builtin-shortcodes
1b620db 
Builtin shortcodes
@ralsina ralsina merged commit 1b620db into master Jan 4, 2016
@ralsina ralsina deleted the builtin-shortcodes branch January 4, 2016 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska