Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scripts #145

Merged
merged 2 commits into from Dec 22, 2015
Merged

Fix scripts #145

merged 2 commits into from Dec 22, 2015

Conversation

shenki
Copy link
Member

@shenki shenki commented Dec 21, 2015

No description provided.

When sourced,

  shenki@icarus ~/dev/foo/HDMI2USB-misoc-firmware $

becomes:

  (HDMI2USB)shenki@icarus ~/dev/foo/HDMI2USB-misoc-firmware $

Signed-off-by: Joel Stanley <joel@jms.id.au>
@@ -127,3 +127,6 @@ echo ""
alias python=python3

export HDMI2USB_ENV=1

# Set prompt
PS1="(HDMI2USB)$PS1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe put the board/target in the prompt?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro I had basename $PWD, but it made the prompt too big.

Will the user have the env variables for driving make set when running setup-env.sh?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the prompt should probably evaluate them every time. I'll merge this now and we can make it better later.

Signed-off-by: Joel Stanley <joel@jms.id.au>
mithro added a commit that referenced this pull request Dec 22, 2015
@mithro mithro merged commit e92a715 into timvideos:master Dec 22, 2015
@shenki shenki deleted the fix-scripts branch April 12, 2016 00:58
mithro added a commit to mithro/HDMI2USB-litex-firmware that referenced this pull request Jun 2, 2019
This change fixes a typo in the Makefile.mk for arty when running firmware-flash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants