-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix.conf: add build-hook-use-substitutes #1228
Conversation
Looks right to me, have you tested it? |
@shlevy not to the full extent of running this in NixOS, but I better do that. Do you know if there's a |
Not sure off the top of my head, but I think all you'll need to do is replace |
@@ -302,6 +302,20 @@ flag, e.g. <literal>--option gc-keep-outputs false</literal>.</para> | |||
</varlistentry> | |||
|
|||
|
|||
<varlistentry><term><literal>build-hook-use-substitutes</literal></term> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this name since "build hook" is just an implementation detail used by the distributed build mechanism.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-remote-use-substitutes
perhaps?
<varlistentry><term><literal>build-hook-use-substitutes</literal></term> | ||
|
||
<listitem><para>If set to <literal>true</literal>, Nix will instruct | ||
remote build hooks to use their own binary substitutes if available. In |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no such thing as "remote build hooks". The build hook is local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"remote building hosts" perhaps?
@k0001 Have you had a chance for a full-stack test of this yet? |
Not yet. I'll try again. Last time this failed for me with an out of memory
error that seemed completely unrelated to this change.
…On Mar 31, 2017 11:32 PM, "Shea Levy" ***@***.***> wrote:
@k0001 <https://github.com/k0001> Have you had a chance for a full-stack
test of this yet?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1228 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAM5g3666l-ulTlb0byN-rvJJZO64RNks5rrXDqgaJpZM4L8WfU>
.
|
I am closing this in favor of #1788 |
This should solve #937
cc @shlevy