Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix.conf: add build-hook-use-substitutes #1228

Closed
wants to merge 1 commit into from
Closed

Conversation

k0001
Copy link
Contributor

@k0001 k0001 commented Feb 9, 2017

This should solve #937

cc @shlevy

@shlevy
Copy link
Member

shlevy commented Feb 9, 2017

Looks right to me, have you tested it?

@shlevy shlevy self-assigned this Feb 9, 2017
@k0001
Copy link
Contributor Author

k0001 commented Feb 9, 2017

@shlevy not to the full extent of running this in NixOS, but I better do that.

Do you know if there's a nixos/modules/misc/nix-daemon.nix somewhere that works with the latest nix HEAD?

@shlevy
Copy link
Member

shlevy commented Feb 9, 2017

Not sure off the top of my head, but I think all you'll need to do is replace build-remote.pl with build-remote

@@ -302,6 +302,20 @@ flag, e.g. <literal>--option gc-keep-outputs false</literal>.</para>
</varlistentry>


<varlistentry><term><literal>build-hook-use-substitutes</literal></term>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this name since "build hook" is just an implementation detail used by the distributed build mechanism.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build-remote-use-substitutes perhaps?

<varlistentry><term><literal>build-hook-use-substitutes</literal></term>

<listitem><para>If set to <literal>true</literal>, Nix will instruct
remote build hooks to use their own binary substitutes if available. In
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such thing as "remote build hooks". The build hook is local.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"remote building hosts" perhaps?

@shlevy
Copy link
Member

shlevy commented Mar 31, 2017

@k0001 Have you had a chance for a full-stack test of this yet?

@k0001
Copy link
Contributor Author

k0001 commented Mar 31, 2017 via email

@k0001
Copy link
Contributor Author

k0001 commented Jan 9, 2018

I am closing this in favor of #1788

@k0001 k0001 closed this Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants