Update scrapy & dependencies #22593
Merged
Update scrapy & dependencies #22593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jozko |
FRidh
approved these changes
Feb 10, 2017
|
@drewkett you ok with these changes? |
|
Looks fine to me, though I'd probably add a comment to the nix file explaining why the permissions patch is needed rather than having that information only be in a commit message. I'm not using this package at the moment, so feel free to take over as maintainer if you'd like. |
|
I left you in as the maintainer for now - I'm not directly using them either, had some unrelated code that needed a newer scrapy. Updated according to your comment. |
|
@FRidh - I think this is ready to merge. |
FRidh
requested changes
Feb 16, 2017
| @@ -0,0 +1,36 @@ | |||
| { self, buildPythonPackage, pkgs, lib }: | |||
There was a problem hiding this comment.
- never pass in
pkgs - python libraries are passed the individual python packages, not pythonPackages or self
…code. Scrapy is usually installed via pip where copying all permissions makes sense. In Nix the files copied are owned by root and readonly. As a consequence scrapy can't edit the project templates so scrapy startproject fails.
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)