Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pygments: 2.1.3 -> 2.2.0 #22863

Merged
merged 2 commits into from Feb 23, 2017
Merged

pygments: 2.1.3 -> 2.2.0 #22863

merged 2 commits into from Feb 23, 2017

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Feb 16, 2017

Motivation for this change

A new version has been released.

Changes:

Version 2.2.0

(release Jan 22, 2017)

  • Added lexers:
    • AMPL
    • TypoScript (Fix remmina the FreeRDP GUI frontend #1173)
    • Varnish config (PR#554)
    • Clean (PR#503)
    • WDiff (PR#513)
    • Flatline (PR#551)
    • Silver (PR#537)
    • HSAIL (PR#518)
    • JSGF (PR#546)
    • NCAR command language (PR#536)
    • Extempore (PR#530)
    • Cap’n Proto (PR#595)
    • Whiley (PR#573)
    • Monte (PR#592)
    • Crystal (PR#576)
    • Snowball (PR#589)
    • CapDL (PR#579)
    • NuSMV (PR#564)
    • SAS, Stata (PR#593)
  • Added the ability to load lexer and formatter classes directly from files with the -x command line option and the lexers.load_lexer_from_file() and formatters.load_formatter_from_file() functions. (PR#559)
  • Added lexers.find_lexer_class_by_name(). (systemctl start openvpn does not prompt for password #1203)
  • Added new token types and lexing for magic methods and variables in Python and PHP.
  • Added a new token type for string affixes and lexing for them in Python, C++ and Postgresql lexers.
  • Added a new token type for heredoc (and similar) string delimiters and lexing for them in C++, Perl, PHP, Postgresql and Ruby lexers.
  • Styles can now define colors with ANSI colors for use in the 256-color terminal formatter. (PR#531)
  • Improved the CSS lexer. ("systemctl list-unit-files" doesn't work #1083, Package to install nix-prefetch-git, nix-prefetch-bzr, ... #1130)
  • Added “Rainbow Dash” style. (PR#623)
  • Delay loading pkg_resources, which takes a long while to import. (PR#690)
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@romildo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh FRidh self-assigned this Feb 16, 2017
@globin globin changed the base branch from master to staging February 17, 2017 15:02
@globin globin self-assigned this Feb 17, 2017
@FRidh
Copy link
Member

FRidh commented Feb 23, 2017

I did a Hydra run on this, and this breaks at least pelican and searx.

  • Pelican is not that important; because it is typically used as an application it is straightforward to use an older version of pygments for it.
  • searx seems to pin exact versions (sigh). @fpletz , is searx used as a Python library, or not? If not, then we can keep the current version of pygments for searx.

If we solve these two issues then I think we can use the latest version of pygments.

The latest version of pygments adds some new features (and one nice fix. I'm not sure whether its worth merging for 17.30. What do you think @romildo ?

@globin
Copy link
Member

globin commented Feb 23, 2017

@FRidh you can simply sed out the hard dependency in searx (done for some of the other dependencies, too)

@FRidh
Copy link
Member

FRidh commented Feb 23, 2017

@globin yes but will it still function properly? That's a risk one takes when removing the hard dependency. This isn't a maintenance bump either but a new feature release.

@fpletz
Copy link
Member

fpletz commented Feb 23, 2017

@FRidh It will probably just work. I'll give it a try. In the meantime this PR can be merged. Searx is in fact an application and is not used a library.

@fpletz
Copy link
Member

fpletz commented Feb 23, 2017

Works. 😃

@FRidh FRidh merged commit 4810677 into NixOS:staging Feb 23, 2017
@FRidh
Copy link
Member

FRidh commented Feb 23, 2017

Great, thanks.

@globin globin removed their assignment Feb 28, 2017
vcunat pushed a commit that referenced this pull request Mar 1, 2017
@FRidh @vcunat
Merge pull request #22863 from romildo/upd.pygments
58286f1 
pygments: 2.1.3 -> 2.2.0
(cherry picked from commit 4810677)
@romildo romildo deleted the upd.pygments branch March 30, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FRidh FRidh

Labels
1.severity: mass-rebuild 6.topic: python 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@romildo @mention-bot @FRidh @globin @fpletz