Update isync-git, with several other improvements #22872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extra dashes are removed from the version number because Nix treats only the first component as the version, i.e. `2015-11-08` is version `2015` with two tags `-11` and `-08`.
|
@ttuegel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny and @dezgeg to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Although there has not been an isync release in several years, development continues upstream at a moderate pace, so it is important that we keep our Git-based version up-to-date.
Besides updating the package, I:
srcto download over HTTPS, andThings done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"(Not Applicable)./result/bin/)