Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default ocaml 402 #22871

Merged
merged 17 commits into from Feb 19, 2017
Merged

Default ocaml 402 #22871

merged 17 commits into from Feb 19, 2017

Conversation

FlorentBecker
Copy link
Contributor

Motivation for this change

ocaml 4.01 is (relatively) ancient this pr conservatively moves ocamlPackages to ocaml 4.02

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [*] NixOS
    • macOS
    • Linux
  • [*] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@FlorentBecker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aske, @vbgl and @sternenseemann to be potential reviewers.

@vbgl
Copy link
Contributor

vbgl commented Feb 17, 2017

Thanks. Applications like llpp or prooftree (which do not provide any OCaml library) should be moved out of ocaml-packages. Looks good otherwise.

@vbgl
Copy link
Contributor

vbgl commented Feb 19, 2017

The commit message of 3ebe650b93019c46800a0f8cd5e2b711b820af26 is wrong.

@FlorentBecker
Copy link
Contributor Author

Fixed.

@vbgl vbgl merged commit d31577c into NixOS:master Feb 19, 2017
@vbgl
Copy link
Contributor

vbgl commented Feb 19, 2017

Thank you.

@FlorentBecker FlorentBecker deleted the default_ocaml_402 branch February 19, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants