Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] dateutil: 2.5.3 -> 2.6.0 #22870

Closed
wants to merge 2 commits into from
Closed

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented Feb 16, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vrthra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@FRidh FRidh self-assigned this Feb 16, 2017
@vrthra vrthra force-pushed the dateutil branch 3 times, most recently from 0ebbea2 to fac04d6 Compare February 19, 2017 23:17
The dateutil module should be called python-dateutil. Its license is bsd3
also, use `six` rather than `self.six` as package dependency
@vrthra
Copy link
Member Author

vrthra commented Feb 19, 2017

The commit 88144373a738fa3a88712cbd11c486c71e834f70 fails on cairocffi eventhough the commit should have been idempotent. Hence, cairocffi is broken.

@vrthra vrthra changed the title dateutil: 2.5.3 -> 2.6.0 [WIP] dateutil: 2.5.3 -> 2.6.0 Feb 20, 2017
@vrthra
Copy link
Member Author

vrthra commented Feb 20, 2017

Fixing cairoffi seems to show that capstone is broken. Can I just mark these as broken and proceed with dateutil?

@FRidh
Copy link
Member

FRidh commented Feb 20, 2017

@vrthra involve the maintainer and try to find a solution together

@7c6f434c
Copy link
Member

@vrthra is it OK to close this PR now that another version of the same update is merged?

@vrthra
Copy link
Member Author

vrthra commented Apr 30, 2017

@7c6f434c Indeed, closing this one.

@vrthra vrthra closed this Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants