crystal-lang · Feb 16, 2017 · Feb 16, 2017 · Feb 16, 2017 · Feb 16, 2017 · Feb 16, 2017
diff --git a/spec/compiler/normalize/select_spec.cr b/spec/compiler/normalize/select_spec.cr
@@ -10,7 +10,7 @@ describe "Normalize: case" do
       when 1
         baz
       else
-        ::raise("Bug: invalid select index")
+        ::raise("BUG: invalid select index")
       end
       CODE
   end
@@ -23,7 +23,7 @@ describe "Normalize: case" do
         x = __temp_2.as(typeof(foo))
         x + 1
       else
-        ::raise("Bug: invalid select index")
+        ::raise("BUG: invalid select index")
       end
       CODE
   end
@@ -48,7 +48,7 @@ describe "Normalize: case" do
         x = __temp_2.as(typeof(foo?))
         x + 1
       else
-        ::raise("Bug: invalid select index")
+        ::raise("BUG: invalid select index")
       end
       CODE
   end
@@ -61,7 +61,7 @@ describe "Normalize: case" do
         x = __temp_2.as(typeof(foo!))
         x + 1
       else
-        ::raise("Bug: invalid select index")
+        ::raise("BUG: invalid select index")
       end
       CODE
   end

diff --git a/spec/spec_helper.cr b/spec/spec_helper.cr
@@ -219,21 +219,21 @@ def assert_syntax_error(str, message = nil, line = nil, column = nil, metafile =
   it "says syntax error on #{str.inspect}", metafile, metaline, metaendline do
     begin
       parse str
-      fail "expected SyntaxException to be raised", metafile, metaline
+      fail "Expected SyntaxException to be raised", metafile, metaline
     rescue ex : SyntaxException
       if message
         unless ex.message.not_nil!.includes?(message.not_nil!)
-          fail "expected message to include #{message.inspect} but got #{ex.message.inspect}", metafile, metaline
+          fail "Expected message to include #{message.inspect} but got #{ex.message.inspect}", metafile, metaline
         end
       end
       if line
         unless ex.line_number == line
-          fail "expected line number to be #{line} but got #{ex.line_number}", metafile, metaline
+          fail "Expected line number to be #{line} but got #{ex.line_number}", metafile, metaline
         end
       end
       if column
         unless ex.column_number == column
-          fail "expected column number to be #{column} but got #{ex.column_number}", metafile, metaline
+          fail "Expected column number to be #{column} but got #{ex.column_number}", metafile, metaline
         end
       end
     end

diff --git a/spec/std/array_spec.cr b/spec/std/array_spec.cr
@@ -26,13 +26,13 @@ describe "Array" do
     end
 
     it "raises on negative count" do
-      expect_raises(ArgumentError, "negative array size") do
+      expect_raises(ArgumentError, "Negative array size") do
         Array.new(-1, 3)
       end
     end
 
     it "raises on negative capacity" do
-      expect_raises(ArgumentError, "negative array size") do
+      expect_raises(ArgumentError, "Negative array size") do
         Array(Int32).new(-1)
       end
     end
@@ -176,13 +176,13 @@ describe "Array" do
     end
 
     it "raises on negative count" do
-      expect_raises ArgumentError, /negative count: -1/ do
+      expect_raises ArgumentError, /Negative count: -1/ do
         [1, 2, 3][1, -1]
       end
     end
 
     it "raises on negative count on empty Array" do
-      expect_raises ArgumentError, /negative count: -1/ do
+      expect_raises ArgumentError, /Negative count: -1/ do
         Array(Int32).new[0, -1]
       end
     end
@@ -260,7 +260,7 @@ describe "Array" do
       a[1, 3] = 6
       a.should eq([1, 6, 5, 6, 7, 8])
 
-      expect_raises ArgumentError, "negative count" do
+      expect_raises ArgumentError, "Negative count" do
         [1, 2, 3][0, -1]
       end
 
@@ -1471,7 +1471,7 @@ describe "Array" do
     it { [1, 2, 3].permutations(3).should eq([[1, 2, 3], [1, 3, 2], [2, 1, 3], [2, 3, 1], [3, 1, 2], [3, 2, 1]]) }
     it { [1, 2, 3].permutations(0).should eq([[] of Int32]) }
     it { [1, 2, 3].permutations(4).should eq([] of Array(Int32)) }
-    it { expect_raises(ArgumentError, "size must be positive") { [1].permutations(-1) } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].permutations(-1) } }
 
     it "accepts a block" do
       sums = [] of Int32
@@ -1502,7 +1502,7 @@ describe "Array" do
       object_ids.size.should eq(1)
     end
 
-    it { expect_raises(ArgumentError, "size must be positive") { [1].each_permutation(-1) { } } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].each_permutation(-1) { } } }
 
     it "returns iterator" do
       a = [1, 2, 3]
@@ -1555,7 +1555,7 @@ describe "Array" do
     it { [1, 2, 3].combinations(4).should eq([] of Array(Int32)) }
     it { [1, 2, 3, 4].combinations(3).should eq([[1, 2, 3], [1, 2, 4], [1, 3, 4], [2, 3, 4]]) }
     it { [1, 2, 3, 4].combinations(2).should eq([[1, 2], [1, 3], [1, 4], [2, 3], [2, 4], [3, 4]]) }
-    it { expect_raises(ArgumentError, "size must be positive") { [1].combinations(-1) } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].combinations(-1) } }
 
     it "accepts a block" do
       sums = [] of Int32
@@ -1595,7 +1595,7 @@ describe "Array" do
       sums.should eq([3, 4, 5])
     end
 
-    it { expect_raises(ArgumentError, "size must be positive") { [1].each_combination(-1) { } } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].each_combination(-1) { } } }
 
     it "returns iterator" do
       a = [1, 2, 3, 4]
@@ -1646,7 +1646,7 @@ describe "Array" do
     it { [1, 2, 3].repeated_combinations(3).should eq([[1, 1, 1], [1, 1, 2], [1, 1, 3], [1, 2, 2], [1, 2, 3], [1, 3, 3], [2, 2, 2], [2, 2, 3], [2, 3, 3], [3, 3, 3]]) }
     it { [1, 2, 3].repeated_combinations(0).should eq([[] of Int32]) }
     it { [1, 2, 3].repeated_combinations(4).should eq([[1, 1, 1, 1], [1, 1, 1, 2], [1, 1, 1, 3], [1, 1, 2, 2], [1, 1, 2, 3], [1, 1, 3, 3], [1, 2, 2, 2], [1, 2, 2, 3], [1, 2, 3, 3], [1, 3, 3, 3], [2, 2, 2, 2], [2, 2, 2, 3], [2, 2, 3, 3], [2, 3, 3, 3], [3, 3, 3, 3]]) }
-    it { expect_raises(ArgumentError, "size must be positive") { [1].repeated_combinations(-1) } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].repeated_combinations(-1) } }
 
     it "accepts a block" do
       sums = [] of Int32
@@ -1665,7 +1665,7 @@ describe "Array" do
       sums.should eq([6, 7, 8, 8, 9, 10, 9, 10, 11, 12])
     end
 
-    it { expect_raises(ArgumentError, "size must be positive") { [1].each_repeated_combination(-1) { } } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].each_repeated_combination(-1) { } } }
 
     it "yields with reuse = true" do
       sums = [] of Int32
@@ -1739,7 +1739,7 @@ describe "Array" do
     it { [1, 2, 3].repeated_permutations(3).should eq([[1, 1, 1], [1, 1, 2], [1, 1, 3], [1, 2, 1], [1, 2, 2], [1, 2, 3], [1, 3, 1], [1, 3, 2], [1, 3, 3], [2, 1, 1], [2, 1, 2], [2, 1, 3], [2, 2, 1], [2, 2, 2], [2, 2, 3], [2, 3, 1], [2, 3, 2], [2, 3, 3], [3, 1, 1], [3, 1, 2], [3, 1, 3], [3, 2, 1], [3, 2, 2], [3, 2, 3], [3, 3, 1], [3, 3, 2], [3, 3, 3]]) }
     it { [1, 2, 3].repeated_permutations(0).should eq([[] of Int32]) }
     it { [1, 2, 3].repeated_permutations(4).should eq([[1, 1, 1, 1], [1, 1, 1, 2], [1, 1, 1, 3], [1, 1, 2, 1], [1, 1, 2, 2], [1, 1, 2, 3], [1, 1, 3, 1], [1, 1, 3, 2], [1, 1, 3, 3], [1, 2, 1, 1], [1, 2, 1, 2], [1, 2, 1, 3], [1, 2, 2, 1], [1, 2, 2, 2], [1, 2, 2, 3], [1, 2, 3, 1], [1, 2, 3, 2], [1, 2, 3, 3], [1, 3, 1, 1], [1, 3, 1, 2], [1, 3, 1, 3], [1, 3, 2, 1], [1, 3, 2, 2], [1, 3, 2, 3], [1, 3, 3, 1], [1, 3, 3, 2], [1, 3, 3, 3], [2, 1, 1, 1], [2, 1, 1, 2], [2, 1, 1, 3], [2, 1, 2, 1], [2, 1, 2, 2], [2, 1, 2, 3], [2, 1, 3, 1], [2, 1, 3, 2], [2, 1, 3, 3], [2, 2, 1, 1], [2, 2, 1, 2], [2, 2, 1, 3], [2, 2, 2, 1], [2, 2, 2, 2], [2, 2, 2, 3], [2, 2, 3, 1], [2, 2, 3, 2], [2, 2, 3, 3], [2, 3, 1, 1], [2, 3, 1, 2], [2, 3, 1, 3], [2, 3, 2, 1], [2, 3, 2, 2], [2, 3, 2, 3], [2, 3, 3, 1], [2, 3, 3, 2], [2, 3, 3, 3], [3, 1, 1, 1], [3, 1, 1, 2], [3, 1, 1, 3], [3, 1, 2, 1], [3, 1, 2, 2], [3, 1, 2, 3], [3, 1, 3, 1], [3, 1, 3, 2], [3, 1, 3, 3], [3, 2, 1, 1], [3, 2, 1, 2], [3, 2, 1, 3], [3, 2, 2, 1], [3, 2, 2, 2], [3, 2, 2, 3], [3, 2, 3, 1], [3, 2, 3, 2], [3, 2, 3, 3], [3, 3, 1, 1], [3, 3, 1, 2], [3, 3, 1, 3], [3, 3, 2, 1], [3, 3, 2, 2], [3, 3, 2, 3], [3, 3, 3, 1], [3, 3, 3, 2], [3, 3, 3, 3]]) }
-    it { expect_raises(ArgumentError, "size must be positive") { [1].repeated_permutations(-1) } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].repeated_permutations(-1) } }
 
     it "accepts a block" do
       sums = [] of Int32
@@ -1781,7 +1781,7 @@ describe "Array" do
       sums.should eq([6, 7, 8, 7, 8, 9, 8, 9, 10, 7, 8, 9, 8, 9, 10, 9, 10, 11, 8, 9, 10, 9, 10, 11, 10, 11, 12])
     end
 
-    it { expect_raises(ArgumentError, "size must be positive") { [1].each_repeated_permutation(-1) { } } }
+    it { expect_raises(ArgumentError, "Size must be positive") { [1].each_repeated_permutation(-1) { } } }
   end
 
   describe "Array.each_product" do

diff --git a/spec/std/big/big_int_spec.cr b/spec/std/big/big_int_spec.cr
@@ -25,7 +25,7 @@ describe "BigInt" do
   end
 
   it "raises if creates from string but invalid" do
-    expect_raises ArgumentError, "invalid BigInt: 123 hello 456" do
+    expect_raises ArgumentError, "Invalid BigInt: 123 hello 456" do
       BigInt.new("123 hello 456")
     end
   end

diff --git a/spec/std/char_spec.cr b/spec/std/char_spec.cr
@@ -212,13 +212,13 @@ describe "Char" do
   end
 
   it "to_i rejects unsupported base (1)" do
-    expect_raises ArgumentError, "invalid base 1" do
+    expect_raises ArgumentError, "Invalid base 1" do
       '0'.to_i(1)
     end
   end
 
   it "to_i rejects unsupported base (37)" do
-    expect_raises ArgumentError, "invalid base 37" do
+    expect_raises ArgumentError, "Invalid base 37" do
       '0'.to_i(37)
     end
   end

diff --git a/spec/std/colorize_spec.cr b/spec/std/colorize_spec.cr
@@ -76,19 +76,19 @@ describe "colorize" do
   end
 
   it "raises on unknown foreground color" do
-    expect_raises ArgumentError, "unknown color: brown" do
+    expect_raises ArgumentError, "Unknown color: brown" do
       "hello".colorize(:brown)
     end
   end
 
   it "raises on unknown background color" do
-    expect_raises ArgumentError, "unknown color: brown" do
+    expect_raises ArgumentError, "Unknown color: brown" do
       "hello".colorize.back(:brown)
     end
   end
 
   it "raises on unknown mode" do
-    expect_raises ArgumentError, "unknown mode: bad" do
+    expect_raises ArgumentError, "Unknown mode: bad" do
       "hello".colorize.mode(:bad)
     end
   end

diff --git a/spec/std/csv/csv_lex_spec.cr b/spec/std/csv/csv_lex_spec.cr
@@ -122,21 +122,21 @@ describe CSV do
     end
 
     it "raises if single quote in the middle" do
-      expect_raises CSV::MalformedCSVError, "unexpected quote at 1:4" do
+      expect_raises CSV::MalformedCSVError, "Unexpected quote at 1:4" do
         lexer = CSV::Lexer.new %(hel"lo)
         lexer.next_token
       end
     end
 
     it "raises if command, newline or end doesn't follow quote" do
-      expect_raises CSV::MalformedCSVError, "expecting comma, newline or end, not 'a' at 1:6" do
+      expect_raises CSV::MalformedCSVError, "Expecting comma, newline or end, not 'a' at 1:6" do
         lexer = CSV::Lexer.new %("hel"a)
         lexer.next_token
       end
     end
 
     it "raises on unclosed quote" do
-      expect_raises CSV::MalformedCSVError, "unclosed quote at 1:5" do
+      expect_raises CSV::MalformedCSVError, "Unclosed quote at 1:5" do
         lexer = CSV::Lexer.new %("foo)
         lexer.next_token
       end

diff --git a/spec/std/csv/csv_parse_spec.cr b/spec/std/csv/csv_parse_spec.cr
@@ -50,19 +50,19 @@ describe CSV do
     end
 
     it "raises if single quote in the middle" do
-      expect_raises CSV::MalformedCSVError, "unexpected quote at 1:4" do
+      expect_raises CSV::MalformedCSVError, "Unexpected quote at 1:4" do
         CSV.parse(%(hel"lo))
       end
     end
 
     it "raises if command, newline or end doesn't follow quote" do
-      expect_raises CSV::MalformedCSVError, "expecting comma, newline or end, not 'a' at 2:6" do
+      expect_raises CSV::MalformedCSVError, "Expecting comma, newline or end, not 'a' at 2:6" do
         CSV.parse(%(foo\n"hel"a))
       end
     end
 
     it "raises if command, newline or end doesn't follow quote (2)" do
-      expect_raises CSV::MalformedCSVError, "expecting comma, newline or end, not 'a' at 2:6" do
+      expect_raises CSV::MalformedCSVError, "Expecting comma, newline or end, not 'a' at 2:6" do
         CSV.parse(%(\n"hel"a))
       end
     end

diff --git a/spec/std/csv/csv_spec.cr b/spec/std/csv/csv_spec.cr
@@ -18,7 +18,7 @@ describe CSV do
 
   it "raises if trying to access before first row" do
     csv = new_csv headers: true
-    expect_raises(CSV::Error, "before first row") do
+    expect_raises(CSV::Error, "Before first row") do
       csv["one"]
     end
   end
@@ -43,7 +43,7 @@ describe CSV do
 
     csv.next.should be_false
 
-    expect_raises(CSV::Error, "after last row") do
+    expect_raises(CSV::Error, "After last row") do
       csv["one"]
     end
   end

diff --git a/spec/std/deque_spec.cr b/spec/std/deque_spec.cr
@@ -112,13 +112,13 @@ describe "Deque" do
     end
 
     it "raises on negative count" do
-      expect_raises(ArgumentError, "negative deque size") do
+      expect_raises(ArgumentError, "Negative deque size") do
         Deque.new(-1, 3)
       end
     end
 
     it "raises on negative capacity" do
-      expect_raises(ArgumentError, "negative deque capacity") do
+      expect_raises(ArgumentError, "Negative deque capacity") do
         Deque(Int32).new(-1)
       end
     end

diff --git a/spec/std/dir_spec.cr b/spec/std/dir_spec.cr
@@ -7,7 +7,7 @@ end
 
 private def it_raises_on_null_byte(operation, &block)
   it "errors on #{operation}" do
-    expect_raises(ArgumentError, "string contains null byte") do
+    expect_raises(ArgumentError, "String contains null byte") do
       block.call
     end
   end

diff --git a/spec/std/enumerable_spec.cr b/spec/std/enumerable_spec.cr
@@ -472,7 +472,7 @@ describe "Enumerable" do
     it { [1, 2, 3].in_groups_of(2, "x").should eq([[1, 2], [3, "x"]]) }
 
     it "raises argument error if size is less than 0" do
-      expect_raises ArgumentError, "size must be positive" do
+      expect_raises ArgumentError, "Size must be positive" do
         [1, 2, 3].in_groups_of(0)
       end
     end

diff --git a/spec/std/file_spec.cr b/spec/std/file_spec.cr
@@ -22,7 +22,7 @@ end
 
 private def it_raises_on_null_byte(operation, &block)
   it "errors on #{operation}" do
-    expect_raises(ArgumentError, "string contains null byte") do
+    expect_raises(ArgumentError, "String contains null byte") do
       block.call
     end
   end
@@ -623,7 +623,7 @@ describe "File" do
   it "raises if invoking seek with a closed file" do
     file = File.new("#{__DIR__}/data/test_file.txt")
     file.close
-    expect_raises(IO::Error, "closed stream") { file.seek(1) }
+    expect_raises(IO::Error, "Closed stream") { file.seek(1) }
   end
 
   it "returns the current read position with tell" do
@@ -646,7 +646,7 @@ describe "File" do
   it "raises if invoking tell with a closed file" do
     file = File.new("#{__DIR__}/data/test_file.txt")
     file.close
-    expect_raises(IO::Error, "closed stream") { file.tell }
+    expect_raises(IO::Error, "Closed stream") { file.tell }
   end
 
   it "iterates with each_char" do
@@ -766,15 +766,15 @@ describe "File" do
 
     begin
       File.open(filename) do |io|
-        expect_raises(ArgumentError, "negative bytesize") do
+        expect_raises(ArgumentError, "Negative bytesize") do
           io.read_at(3, -1) { }
         end
 
-        expect_raises(ArgumentError, "offset out of bounds") do
+        expect_raises(ArgumentError, "Offset out of bounds") do
           io.read_at(12, 1) { }
         end
 
-        expect_raises(ArgumentError, "bytesize out of bounds") do
+        expect_raises(ArgumentError, "Bytesize out of bounds") do
           io.read_at(6, 6) { }
         end
       end
@@ -935,13 +935,13 @@ describe "File" do
       io = File.open(__FILE__, "r")
       io.close
 
-      expect_raises(IO::Error, "closed stream") { io.gets_to_end }
-      expect_raises(IO::Error, "closed stream") { io.print "hi" }
-      expect_raises(IO::Error, "closed stream") { io.puts "hi" }
-      expect_raises(IO::Error, "closed stream") { io.seek(1) }
-      expect_raises(IO::Error, "closed stream") { io.gets }
-      expect_raises(IO::Error, "closed stream") { io.read_byte }
-      expect_raises(IO::Error, "closed stream") { io.write_byte('a'.ord.to_u8) }
+      expect_raises(IO::Error, "Closed stream") { io.gets_to_end }
+      expect_raises(IO::Error, "Closed stream") { io.print "hi" }
+      expect_raises(IO::Error, "Closed stream") { io.puts "hi" }
+      expect_raises(IO::Error, "Closed stream") { io.seek(1) }
+      expect_raises(IO::Error, "Closed stream") { io.gets }
+      expect_raises(IO::Error, "Closed stream") { io.read_byte }
+      expect_raises(IO::Error, "Closed stream") { io.write_byte('a'.ord.to_u8) }
     end
   end
 

diff --git a/spec/std/file_utils_spec.cr b/spec/std/file_utils_spec.cr
@@ -111,7 +111,7 @@ describe "FileUtils" do
     end
 
     it "raises an error if the directory doesn't exists" do
-      expect_raises(ArgumentError, "no such directory : not_existing_dir") do
+      expect_raises(ArgumentError, "No such directory : not_existing_dir") do
         FileUtils.cp({File.join(__DIR__, "data/test_file.text")}, "not_existing_dir")
       end
     end