ptask: init at 1.0.0 #23062
ptask: init at 1.0.0 #23062
Conversation
| sha256 = "13nirr7b29bv3w2zc8zxphhmc9ayhs61i11jl4819nabk7vy1kdq"; | ||
| }; | ||
|
|
||
| buildInputs = [ pkgconfig makeWrapper gtk3 json_c ]; |
There was a problem hiding this comment.
pkgconfig and makeWrapper are nativeBuildInputs.
| @@ -0,0 +1,29 @@ | |||
| { stdenv, fetchurl, pkgconfig, makeWrapper, gtk3, json_c, taskwarrior }: | |||
There was a problem hiding this comment.
You have taskwarrior here in the input of the function, but not in any buildinputs.
There was a problem hiding this comment.
It appears in the call to wrapProgram as it is a run-time dependency.
| || !strcmp(ver, "2.4.0") | ||
| || !strcmp(ver, "2.4.1") | ||
| - || !strcmp(ver, "2.5.0")) | ||
| + || !strcmp(ver, "2.5.1")) |
There was a problem hiding this comment.
I can see why we need this patch, but I would really opt for contributing this upstream as well... I'm not sure why there is still the 2.5.0 version in here... Maybe both work? Have you tested it?
There was a problem hiding this comment.
I haven't had the time yet to contribute it upstream. ptask has a --force switch to circumvent this check, but this obviously degrades usability. It does work, though, as 2.5.1 is a maintenance release. I would leave the patch until it is fixed upstream. As ptask is meant to be a graphical interface, it does not make a lot of sense to force the user to go back to the terminal to make it work.
|
@fpletz, @matthiasbeyer Are we good to merge, now? I think I addressed all concerns. |
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)