bfg-repo-cleaner: init at 1.12.15 #22694
Conversation
|
@changlinli, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benley, @zimbatm and @edolstra to be potential reviewers. |
| license = licenses.gpl3; | ||
| maintainers = [ maintainers.changlinli ]; | ||
| platforms = platforms.unix; | ||
| downloadPage = "https://mvnrepository.com/artifact/com.madgag/bfg/1.12.15"; |
There was a problem hiding this comment.
You probably ought to substitute in the version number from the variable defined up above here - or perhaps just omit the versioned part of the url and link to the page listing all versions?
There was a problem hiding this comment.
Ah yes; I was being silly and completely forgot to put that in after pulling it out as a variable earlier. One sec while I change that... (assuming that there isn't a preference to just omit the versioned part of the url)
There was a problem hiding this comment.
Up to you - either way would be OK I think.
There was a problem hiding this comment.
Cool; I'm assuming then I should just redo this commit and force push rather than introduce a new commit?
|
Looks great, thanks! |
Motivation for this change
Packaging up the BFG repo cleaner for Git (a nice little git-history-rewrite tool that's a fast way of removing unwanted data from git history).
Tested by building
nix-build -A gitAndTools.bfg-repo-cleaner <my local nixpkgs>/default.nixand deleting a file from the history one of my git repos.Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)