[WIP] cairocffi: 0.7.2 -> 0.8.0 #22693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ffi fails on mac because it tries to load |
vrthra
commented
Feb 13, 2017
pkgs/top-level/python-packages.nix
Outdated
| @@ -3468,11 +3463,16 @@ in { | |||
| substituteInPlace cairocffi/__init__.py --subst-var-by cairo ${pkgs.cairo.out} | |||
| substituteInPlace cairocffi/__init__.py --subst-var-by glib ${pkgs.glib.out} | |||
| substituteInPlace cairocffi/__init__.py --subst-var-by gdk_pixbuf ${pkgs.gdk_pixbuf.out} | |||
| ''; | |||
| '' + optionalString (stdenv.isDarwin) '' | |||
There was a problem hiding this comment.
I would like to know if there is a better way to do this.
vrthra
force-pushed
the
cairocffi
branch
3 times, most recently
from
e3d5064
to
6d1f198
Compare
vrthra
force-pushed
the
cairocffi
branch
4 times, most recently
from
6f791ca
to
e0652c1
Compare
vrthra
force-pushed
the
cairocffi
branch
3 times, most recently
from
a7d94b6
to
263b5c8
Compare
|
I completely forgot about this PR. What is the status of it? |
|
Sorry, wasn't able to focus on this yet. |
|
Updated in #35527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)