Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creduce: init at 2.6.0 #22680

Merged
merged 1 commit into from Feb 17, 2017
Merged

creduce: init at 2.6.0 #22680

merged 1 commit into from Feb 17, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 11, 2017

Also includes perl dependency 'GetOpt::Tabular'.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

enableParallelBuilding = true;

meta = with stdenv.lib; {
description = "a C program reducer";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capitalize the description

@joachifm
Copy link
Contributor

The travis output indicates that the darwin build is quite broken, it fails to resolve e.g., #include <string>

@dtzWill
Copy link
Member Author

dtzWill commented Feb 11, 2017

Thanks for the review and for alerting me to the Darwin failure--I've attempted to fix it, let's see what Travis says this time :).

EDIT: Looks like Darwin at least didn't die immediately, fingers crossed! https://api.travis-ci.org/jobs/200739313/log.txt?deansi=true

Also includes perl dependency 'GetOpt::Tabular'.
@dtzWill
Copy link
Member Author

dtzWill commented Feb 12, 2017

(rebased+squashed)

@dtzWill
Copy link
Member Author

dtzWill commented Feb 14, 2017

(Darwin builder failure is noise, the builder timed out)

@joachifm joachifm merged commit fe45524 into NixOS:master Feb 17, 2017
@dtzWill dtzWill deleted the feature/creduce branch February 17, 2017 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants