Drop kdm and kde4 modules #22677
Merged
Drop kdm and kde4 modules #22677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excluding modules/programs/environment.nix for PATHand QT_PLUGIN_PATH to allow the programs to continue running.
That should be fine. |
|
As a data point on quassel, I'm using the qt5 version and it seems fine. In all fairness my total experience with IRC clients in general is a whopping 12 hours so I may not have exercised all the features... |
|
👍 |
kierdavis
reviewed
Feb 15, 2017
| @@ -25,12 +25,12 @@ in | |||
|
|
|||
| package = mkOption { | |||
| type = types.package; | |||
| default = pkgs.kde4.quasselDaemon; | |||
| defaultText = "pkgs.kde4.quasselDaemon"; | |||
| default = pkgs.quasselDaemon_qt5; | |||
There was a problem hiding this comment.
I might be missing something here but it doesn't looks like quasselDaemon_qt5 exists in all-packages.nix. I think this should quasselDaemon (which is still qt5).
kierdavis
added a commit
to kierdavis/nixpkgs
that referenced
this pull request
Feb 15, 2017
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
re: #15866
cc: @ttuegel @vcunat @globin @domenkozar @dezgeg @fpletz @edolstra
One thing I'm not sure about is reverting @Phreedom's pinning of Quassel to KDE4.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)