Add option to power up bluetooth controller #22685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 12, 2017
| wantedBy = [ "bluetooth.target" ]; | ||
| aliases = [ "dbus-org.bluez.service" ]; | ||
| systemd-udevd.serviceConfig.RestrictAddressFamilies = | ||
| "AF_UNIX AF_NETLINK AF_INET AF_INET6 AF_BLUETOOTH"; |
There was a problem hiding this comment.
I would prefer a service with the correct permissions rather then changing security defaults of udevd. A service can be started from udev using:
ACTION=="add", KERNEL=="hci[0-9]*", ENV{SYSTEMD_WANTS}="bluetooth-power@%k.service"
I don't know if %k can be used above in the way I did.
# bluetooth-power@.service
[Unit]
Description=Bluetooth auto power on
After=bluetooth.service sys-subsystem-bluetooth-devices-%i.device suspend.target
[Service]
Type=oneshot
ExecStart=${pkgs.bluez}/bin/hciconfig %i up
[Install]
WantedBy=suspend.target
There was a problem hiding this comment.
Yes, this works as well.
globin
approved these changes
Feb 14, 2017
|
Merge? |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I have been using a udev rule to automatically power up the default bluetooth controller however after the upgrade to systemd 232 this method stopped working due to a change in the systemd-udevd unit.
A possible fix (found here) is to add
AF_BLUETOOTHto theRestrictAddressFamiliesoption.So I added this fix and also an handy option which implements the power up rule.
Things done
I tested this change and it's working ok.