Skip to content

Commit

Permalink
pythonPackages.argparse: only for Python < 2.7
Browse files Browse the repository at this point in the history 
(cherry picked from commit bee23d7)
  • Loading branch information
@FRidh
FRidh committed Feb 12, 2017
1 parent 4eb92c5 commit c901d5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkgs/top-level/python-packages.nix
View file
Expand Up @@ -1103,7 +1103,7 @@ in modules // {

};

argparse = buildPythonPackage (rec {
argparse = if (pythonAtLeast "2.7") then null else buildPythonPackage (rec {
name = "argparse-1.4.0";

src = pkgs.fetchurl {
Expand Down

4 comments on commit c901d5b

@aszlig
Copy link
Member

@aszlig aszlig commented on c901d5b Feb 12, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks pythonPackages.unittest2: https://headcounter.org/hydra/log/xg4j02a6vrgvjhdq840lpzax1q5m0gv2-python2.7-unittest2-1.1.0.drv

@vcunat
Copy link
Member

@vcunat vcunat commented on c901d5b Feb 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh: here the commit was intentional if it wasn't so on master?

@FRidh
Copy link
Member Author

@FRidh FRidh commented on c901d5b Feb 12, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcunat on 16.09 it was intentional, on master it wasn't - there it had to go into staging.

@RonnyPfannschmidt , should packages explicitly depend on unittest2? If I am correct its a backport that's unneeded for 2.7 and above.

@RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented on c901d5b Feb 12, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRidh packages that use/depend on it tend to use the different imports it uses

edit

note that some packages gracefully fall back to not needing it

Please sign in to comment.