MBS-9166: make guess case ignore "Early" unless already in parens #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would prefer a commit description that properly describes what the change is. Noone will know what “ignore ‘Early’” means: Ignore it by removing it from the text? Ignore it by not changing its casing? Ignore it by treating it like “late”? Ignore it in a different way? |
|
Better? |
mwiencek
approved these changes
Feb 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the most conservative version of MBS-9166 (early will still get lowercased if it's inside parenthesis, but not otherwise).
I get the feeling "dialogue" could get the same treatment too, but letting that one be for now.