KDE: update frameworks and applications #22698
Conversation
|
@FRidh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @phunehehe, @vandenoever and @amiddelk to be potential reviewers. |
|
Some packages are still being build. |
FRidh
force-pushed
the
kde
branch
3 times, most recently
from
411811b
to
1f1fecf
Compare
| fallbackPackage(0), | ||
| metadata(0), | ||
| fallbackPackage(nullptr), | ||
| metadata(nullptr), | ||
| - externalPaths(false), | ||
| + externalPaths(true), |
There was a problem hiding this comment.
Why are external paths allowed?
KPackage documentation says:
/**
* @return true if paths/symlinks outside the package itself should be followed.
* By default this is set to false for security reasons.
*/
bool allowExternalPaths() const;
There was a problem hiding this comment.
I guess because we use symbolic links in our wrapper.
There was a problem hiding this comment.
You changed the setting, from true to false no? Did you encounter problems when the value was false?
There was a problem hiding this comment.
That change was already present in the previous patch. Note which signs are part of the patch and which are GitHub's.
There was a problem hiding this comment.
I see now. The coloring is also applied to unchanged files. That confused me.
I've no problems with the patch as I read it, but I've not tested it.
There was a problem hiding this comment.
@vandenoever I added this patch. It is required for Plasma to work at all. KDE upstream considers this to be a "security feature" but that's nonsense: if your "security" requires ignoring symlinks, you don't have "security".
|
Three packages fail
|
|
@ttuegel I'm using this branch now without any issues. Merge? |
|
I think we can remove |
|
We can address the removal of old Digikam versions later; most KDE 4 packages will shortly be removed anyway. |
|
There are several new build failures in KDE stuff on staging, most likely due to this merge: http://hydra.nixos.org/eval/1333416?filter=&compare=1333281&full=#tabs-now-fail It often seems like they're due to using a different c++ standard, e.g. those errors about not recognizing |
|
Oh, you discussed this already. Note that it's the new digikam5 that's reported as failing. |
|
Huh, I actually tried |
|
@the-kenny: it was only merged to staging, not master. Now it's in master. |
/cc NixOS#22698 and maintainer @romildo.
|
Oh! That explains it. I can reproduce the issue locally, will try to fix
it later today.
Vladimír Čunát <notifications@github.com> writes:
… @the-kenny: it was only merged to staging, not master. Now it's in master.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#22698 (comment)
--
|
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)