Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support "View source" links for GitLab projects #4024

Merged
merged 1 commit into from Feb 13, 2017
Merged

Support "View source" links for GitLab projects #4024

merged 1 commit into from Feb 13, 2017

Conversation

ezrast
Copy link

@ezrast ezrast commented Feb 12, 2017

Crystal::Doc::Generator#compute_repository is hard-coded to support GitHub; this abstracts out the logic enough to support GitLab as well (and probably others, if someone writes the regex and format strings).

@david50407
Copy link
Contributor

How about extract this out to configurable settings into shards.yml or other config?

These are simple regex matching from git remote url.

@spalladino spalladino added this to the 0.21.0 milestone Feb 13, 2017
@spalladino spalladino merged commit 69cd7c8 into crystal-lang:master Feb 13, 2017
@ezrast
Copy link
Author

ezrast commented Feb 14, 2017

@david50407 Having it in shards.yml makes practical sense to me, but that would imply doc to be a feature of shard rather than of crystal (I don't believe Crystal itself ever reads from shards.yml currently?). I'd be willing to do more work on this, but it probably deserves to have an issue made first if that's something you'd like to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:docs kind:feature
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ezrast @david50407 @spalladino