Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] agate: 1.2.2 -> 1.5.5 #22689

Closed
wants to merge 8 commits into from
Closed

[WIP] agate: 1.2.2 -> 1.5.5 #22689

wants to merge 8 commits into from

Conversation

vrthra
Copy link
Member

@vrthra vrthra commented Feb 11, 2017 •
edited

Motivation for this change

Updating the Agate python library, and its dependencies. All these packages are connected, and I need to enable Python3 for these too. So adding them as one single PR

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@vrthra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@vrthra vrthra changed the title Agate agate: 1.2.2 -> 1.5.5 Feb 11, 2017
@vrthra vrthra force-pushed the agate branch 6 times, most recently from c9d97e4 to e44efbd Compare February 12, 2017 01:00
@vrthra
Copy link
Member Author

vrthra commented Feb 12, 2017 •
edited

The error seems to be no space left on the device, and an unrelated error on python cairocffi. They don't seem related to my commits, and the package that errs out pythonPackages.cairocffi also errors out without my commits on OSX.

@FRidh FRidh self-assigned this Feb 12, 2017
@vrthra vrthra changed the title agate: 1.2.2 -> 1.5.5 [WIP] agate: 1.2.2 -> 1.5.5 Feb 13, 2017
@vrthra
Copy link
Member Author

vrthra commented Feb 13, 2017

Moving to WIP: I am trying to split this PR into multiple smaller PRs as much as possible.

@FRidh
Copy link
Member

FRidh commented Feb 13, 2017

@vrthra if these packages/updates are all needed for your agate update, then do not split it into multiple PR's.

@FRidh
Copy link
Member

FRidh commented Feb 13, 2017

also, please put new expressions in pkgs/development/python-modules/

@vrthra
Copy link
Member Author

vrthra commented Feb 13, 2017

@FRidh thanks, I didn't know if my PR was too large for review. I will add them back, and use python-modules for new expressions.

FRidh
FRidh requested changes Feb 13, 2017
View reviewed changes
pkgs/top-level/python-packages.nix
@@ -144,14 +160,36 @@ in {
maintainers = with maintainers; [ vrthra ];
};

doCheck = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please include a comments explaining why you disabled the tests

@vrthra vrthra mentioned this pull request Feb 14, 2017
Merged
7 tasks
@vrthra vrthra force-pushed the agate branch 2 times, most recently from 9b52c01 to aaa70ca Compare February 16, 2017 15:34
@vrthra vrthra closed this May 1, 2017
@vrthra
Copy link
Member Author

vrthra commented May 1, 2017

Moving to #25404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees

@FRidh FRidh

Labels
2.status: work-in-progress 6.topic: python 8.has: package (new) 8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vrthra @mention-bot @FRidh