zookeeper: 3.4.6 -> 3.4.9 #22205
Closed
zookeeper: 3.4.6 -> 3.4.9 #22205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pradeepchhetri, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nathan-gs and @cstrahan to be potential reviewers. |
|
Works fine for me. Rebased into master in a8b6988. Many thanks! |
|
@rycee you know that you can rebase on the github page? That marks the PR as merged, not closed. :) |
|
@globin, Yeah, but since I have to checkout the PR, rebase it onto master and test it locally anyway it seems easier to just commit it from the command line as well. If it would be possible for git-hub to mark the PR as merged rather than closed, that would be best. Is it a big problem that the PRs are marked as closed rather then merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)