Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk8: 8u122-04 -> 8u121-13 #22189

Merged
merged 1 commit into from Jan 27, 2017
Merged

openjdk8: 8u122-04 -> 8u121-13 #22189

merged 1 commit into from Jan 27, 2017

Conversation

NeQuissimus
Copy link
Member

Motivation for this change

OK, so this is an odd one in terms of versioning :)

  1. 8u121-13 is newer code than 8u122-04
  2. 8u122 does not exist anymore
  3. 8u122-04 was a preview tag, I am unsure we should use those in the first place
  4. This build is now on par with the release Oracle published for Java SE 8 this week
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@NeQuissimus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @wkennington and @cocreature to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Jan 27, 2017

O.o

@grahamc
Copy link
Member

grahamc commented Jan 27, 2017

Should we backport this too?

@NeQuissimus NeQuissimus added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 27, 2017
@NeQuissimus
Copy link
Member Author

Probably, yes.

@grahamc grahamc merged commit 089e38a into NixOS:master Jan 27, 2017
@NeQuissimus NeQuissimus deleted the openjdk8_121_13 branch January 27, 2017 04:07
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NeQuissimus @mention-bot @grahamc @copumpkin @samueldr