Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird, thunderbird-bin: 45.6.0 -> 45.7.0 [Critical security fix] #22202

Merged
merged 1 commit into from Jan 27, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Jan 27, 2017

Motivation for this change
  • Critical security fix
  • Other bug fixes

https://www.mozilla.org/en-US/thunderbird/45.7.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2017-03/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @garbas, @vcunat and @edolstra to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Jan 27, 2017

<3 <3 <3

@grahamc grahamc merged commit 6a8aa53 into NixOS:master Jan 27, 2017
@grahamc
Copy link
Member

grahamc commented Jan 27, 2017

It seems this doesn't cleanly backport. Can you take a look at that?

@grahamc
Copy link
Member

grahamc commented Jan 27, 2017

(Also: huge huge thank you for your regular and prompt attention to these packages, I deeply appreciate it!)

@taku0
Copy link
Contributor Author

taku0 commented Jan 27, 2017

It seems this doesn't cleanly backport. Can you take a look at that?

OK, let me see...

@taku0
Copy link
Contributor Author

taku0 commented Jan 27, 2017

It seems that updateScript is introduced to master but not to release-16-09. Anyway, sources.nix is compatible for both branch. So just taking updates from this branch works. I will make a PR.

@taku0
Copy link
Contributor Author

taku0 commented Jan 27, 2017

Made a PR #22204.

@garbas
Copy link
Member

garbas commented Jan 27, 2017

@taku0 @grahamc should we backport updateScript to release-16-09? it is not going to break anything, just help us keep code up-to-date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants