Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Mark ihaskell as broken. Closes #22047." #22200

Merged
merged 1 commit into from Jan 27, 2017
Merged

Revert "Mark ihaskell as broken. Closes #22047." #22200

merged 1 commit into from Jan 27, 2017

Conversation

globin
Copy link
Member

@globin globin commented Jan 27, 2017

Reverts #22198

cc @teh, broke travis

@mention-bot
Copy link

@globin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edwtjo, @peti and @dezgeg to be potential reviewers.

@globin globin merged commit df1fee3 into master Jan 27, 2017
@globin globin deleted the revert-22198-master branch January 27, 2017 11:39
@teh
Copy link
Contributor

teh commented Jan 27, 2017

Apologies - not sure how to fix this then, will probably suggest removal.

@vcunat
Copy link
Member

vcunat commented Jan 28, 2017

throw should work the way you intended, I believe.

@vcunat
Copy link
Member

vcunat commented Jan 28, 2017

But even that won't work well, as it wouldn't be sensitive to allowBroken etc. I think we should fix buildEnv in this respect.

@vcunat
Copy link
Member

vcunat commented Jan 28, 2017

I now have some WIP on this, expecting a PR this weekend. I hope to also address: #21845, #22102, #7541.

@vcunat vcunat mentioned this pull request Jan 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@globin @mention-bot @teh @vcunat