I forgot to turn off verbose, and the udev rules aren't there. I need to fix those.

OK, I have to ask here... I don't have a clue about how I can make udev rules work. They are already in the /etc/udev/rules.d of the package, but they are not loaded, and I can't get them to load. I could really use some help here, but it is totally undocumented.

@rongcuid

if you haven't done so already, add https://github.com/NixOS/nixpkgs-channels as remote.

git remote add channels https://github.com/NixOS/nixpkgs-channels.git
git fetch channels

Checkout nixpkgs-unstable

git checkout channels/nixpkgs-unstable

Cherry-pick this commit you made.

git cherry-pick 604a2f2f1871fbdf2555f9ec4957f303c4d696e7

Save it as a new branch named stlink-update2 (note the 2)

git checkout -b stlink-update2

And force push to this PR

git push -f origin stlink-update2:stlink-update

cc maintainer @bjornfor

I will test that. But I still want to know how to get those udev rules to work. They are not loaded by any means, despite being in /nix/store/<pkg>/etc/udev/rules.d

I can't help you with that.

@rongcuid: If the udev rules are properly installed by the package ($out/etc/udev/rules.d/) you can enable them on your system with services.udev.packages = [ thepackage ] in /etc/nixos/configuration.nix.

Ah, I see. I will push the new changes once I get back.

Um, tried to force push, experimented with stuff and accidentally deleted the branch...

git push -f origin stlink-update2:stlink-update

This doesn't seem to work. Is the syntax correct?

OK, it's the slash that causes problem. Trying to fix it

Ahh, after some --no-ff magic and now it should be fine.

Note that I don't have time to test udev rules yet, but I am still interested in finding a way to inform the user to add the services.udev line in their config. Alternatively, I can write a module... But since I now shifted to openocd, I would probably not do that.

@bjornfor are these changes okay with out? Now the commits just need to be squashes, but we can do that.

@rongcuid: What is fixed in the first commit? If this is more than a version bump I'd like it documented in the commit message. (You can write that here and I can add it to the commit when squashing.)

Well, first that is what I was told by the Nixpkgs manual to do... Using fix prefix for a version bump.

I also took care of the switch from autotools to cmake.

@rongcuid: Hm, I never heard of that convention. Seems odd. Do you have a link? I removed the "fix/" prefix, squashed and pushed to master (9775a26). Thanks!

Btw, I noticed a couple of things (for possible future work):

1. the pkgconfig file is installed with wrong includedir path. Not sure if it's upstream or us that are messing it up, but it ends up with a version suffix, but in the file system the include dir is version-less. Since this is a new feature (previous versions didn't ship pkgconfig file), I didn't think it was important enough to fix right now.
2. If cmake finds GTK, it'll build some sort of stlink GUI tool. Perhaps we want to add enable building that (optionally).

https://nixos.org/nixpkgs/manual/#idm140737318408432

@rongcuid there's an example where the branch starts with fix ($ git checkout -b 'fix/pkg-name-update'). The branch name doesn't matter, that's just up to you as contributor. One can use this kind of notation to describe better what the branch contains.

Ah, ok.