OpenSSL server socket fixes #3985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sdogruyol It seems that this is the fix we're looking for. Can you try it? |
|
cc @rdp |
|
Not exactly. There is another fix: ensure to close the underlying socket, whatever if it failed to flush pending data. |
|
Related to #4003 |
This avoids leaving a socket in an indeterminate state opened longer than necessary. fixes crystal-lang#3953
HTTP::Server defaults to a keepalive connection (as expected by the spec), but the connection may be closed normally while HTTP::Request is waiting to receive a new request to process, yet `OpenSSL::SSL::Socket#read` raised an exception instead of returning `0` to report an EOF.
IO::Buffered tries to flush pending data when it's closed, but if flushing fails, it won't try to close the IO, which could lead to leaking file descriptors.
|
Now with a fix for #4003. |
ysbaddaden
force-pushed
the
std-openssl-fixes
branch
from
f4e0644
to
695cff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP::Serverthat waits for another request (keepalive).