nixos.pam.oath: Don't ignore 1st factor authentication #22393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wizeman, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @markus2342 and @viric to be potential reviewers. |
|
cc @obadz (who wrote the comment in the code I'm modifying). |
|
I'm looking in to this. |
7 tasks
|
I think this is obsoleted by my PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When setting
security.pam.services.sshd.oathAuth = trueinconfiguration.nix, instead of activating 2nd factor authentication, it seems that the OTP ends up replacing the password authentication, i.e., it ends up turning off 1st factor authentication. This has been better described in #14997.With NixOS 16.09 plus this change, it seems that #14997 is fixed and the OTP now works properly as a 2nd factor. I wasn't able to login anymore by entering an incorrect password followed by a correct OTP.
Please note that I am not a security expert and I'm much less of a PAM expert, so I am not 100% sure that this is the correct way to fix this issue. That said, it seems to work for me.
It might be a good idea to backport this to 16.09.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)