worker: init at 3.8.5 #22716
Merged
worker: init at 3.8.5 #22716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
reviewed
Feb 12, 2017
| meta = with stdenv.lib; { | ||
| description = "a two-pane file manager with advanced file manipulation features"; | ||
| homepage = "http://www.boomerangsworld.de/cms/worker/index.html"; | ||
| licenses = license.gpl2; |
| description = "a two-pane file manager with advanced file manipulation features"; | ||
| homepage = "http://www.boomerangsworld.de/cms/worker/index.html"; | ||
| licenses = license.gpl2; | ||
| maintainers = [ maintainers.ndowens ]; |
There was a problem hiding this comment.
You have to add an entry to lib/maintainers.nix
LnL7
reviewed
Feb 12, 2017
| meta = with stdenv.lib; { | ||
| description = "a two-pane file manager with advanced file manipulation features"; | ||
| homepage = "http://www.boomerangsworld.de/cms/worker/index.html"; | ||
| license = licenses.gpl2; |
There was a problem hiding this comment.
If you add platforms = platforms.unix; hydra will build this for linux and darwin.
lib/maintainers.nix
Outdated
| @@ -336,6 +336,7 @@ | |||
| Nate-Devv = "Nathan Moore <natedevv@gmail.com>"; | |||
| nathan-gs = "Nathan Bijnens <nathan@nathan.gs>"; | |||
| nckx = "Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>"; | |||
| ndowens = "Nathan Owens <ndowens04@gmail.com"; | |||
There was a problem hiding this comment.
not sure, but the > might be needed to make notifications from hydra work when something breaks.
There was a problem hiding this comment.
Fixed, left that out by accident :)
| name = "worker"; | ||
| version = "3.8.5"; | ||
|
|
||
| src = fetchurl { |
There was a problem hiding this comment.
Can you indent this one level, same with the meta section.
There was a problem hiding this comment.
Indented, hopefully to what it should be now
There was a problem hiding this comment.
you missed the closing curly braces :)
|
I also tested this on darwin. |
modified: pkgs/top-level/all-packages.nix
pick 8096649e47 worker: init at 3.8.5
squash 9267acbd46 modified: pkgs/top-level/all-packages.nix
worker: updated default.nix license field
Added myself to lib/maintainers.nix
squash 28173341fa worker: updated default.nix license field
squash b22407cf5c Added myself to lib/maintainers.nix
Fixed indent and added missing > in maintainers.nix
Fixed curly bracket indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
Add worker FM to repo
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)