kodestudio: init at 17.1 #22722
Merged
kodestudio: init at 17.1 #22722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 13, 2017
|
|
||
| urlBase = "https://github.com/Kode/KodeStudio/releases/download/v${version}/KodeStudio-"; | ||
|
|
||
| urlStr = if stdenv.system == "i686-linux" then urlBase + "linux32.tar.gz" |
There was a problem hiding this comment.
Some lines above i686-linux is unsupported.
Mic92
reviewed
Feb 13, 2017
| homepage = http://kode.tech/; | ||
| downloadPage = https://github.com/Kode/KodeStudio/releases; | ||
| license = licenses.mit; | ||
| maintainers = [ "patternspandemic <patternspandemic@live.com>" ]; |
There was a problem hiding this comment.
Please add a new line to lib/maintainers.nix and reference it here, instead of a plain string.
patternspandemic
force-pushed
the
kodestudio
branch
2 times, most recently
from
f04dee1
to
aa3a9e0
Compare
patternspandemic
force-pushed
the
kodestudio
branch
from
aa3a9e0
to
f035129
Compare
patternspandemic
force-pushed
the
kodestudio
branch
from
f035129
to
bb72826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'd like to use Kodestudio on NixOS.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)