antfs-cli and openant: init at unstable-2017-02-11 #22713
Conversation
|
@richardlarocque, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer. |
pkgs/top-level/python-packages.nix
Outdated
| @@ -169,6 +169,26 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| antfs-cli = buildPythonApplication rec { | |||
There was a problem hiding this comment.
Since this is an application, it should go into the directory structure similarly to garmin-uploader.
pkgs/top-level/python-packages.nix
Outdated
| @@ -169,6 +169,26 @@ in { | |||
| }; | |||
| }; | |||
|
|
|||
| antfs-cli = buildPythonApplication rec { | |||
| name = "antfs-cli-${version}"; | |||
| version = "git-2017-02-11"; | |||
There was a problem hiding this comment.
Since the version field is not actually used anywhere in the expression you can inline it into the name field. Note, however, that this will not be interpreted as you might expect. Nix will parse name as antfs-cli-git and the version to 2017-02-11. This is because it starts the version at the first hyphen followed by a digit:
nix-repl> builtins.parseDrvName "antfs-cli-git-2017-02-11"
{ name = "antfs-cli-git"; version = "2017-02-11"; }
Also as per the naming guidelines it should be name = "antfs-cli-unstable-2017-02-11";.
This comment also applies for the openant package below.
richardlarocque
force-pushed
the
antfs-cli
branch
from
ec6cfc1
to
66ca6dd
Compare
|
Thanks for the quick review! I'm not so quick myself, so feel free to take your time on the second round. I've fixed a few things and squashed my fixes. Changes include:
|
pkgs/top-level/python-packages.nix
Outdated
|
|
||
| # Removes some setup.py hacks intended to install udev rules. | ||
| # We do the job ourselves in postInstall below. | ||
| patchPhase = '' |
There was a problem hiding this comment.
make it postPatch since that allows us to still pass in patches`
|
Beside the @FRidh's point about |
richardlarocque
force-pushed
the
antfs-cli
branch
from
66ca6dd
to
13884d6
Compare
richardlarocque
changed the title
|
Replaced |
Motivation for this change
Adds
antfs-cliand theopenantlibrary it depends on to nixpkgs.These packages seem to not have had any formal release and their version numbers haven't been updated in a long time, so I decided to package them as a Git snapshot rather than aiming for a particular (non-existent) release.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)