gcalcli: init at 3.4.0 #22725
Merged
gcalcli: init at 3.4.0 #22725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Feb 13, 2017
| @@ -0,0 +1,30 @@ | |||
| { stdenv, fetchFromGitHub, pkgs, lib, python, pythonPackages }: | |||
There was a problem hiding this comment.
stdenvis not used.- never pass in
pkgs. - pass in either
pythonorpythonPackages, no need for both. You can accesspythonPackagesviapython.pkgsand the interpreter withpythonPackages.python.
There was a problem hiding this comment.
Thanks for the feedback. I'm still new to Nix... I'll get that updated.
| meta = with lib; { | ||
| homepage = https://github.com/insanum/gcalcli; | ||
| description = "CLI for Google Calendar"; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
are you going to maintain this package?
nocoolnametom
commented
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)