Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: init at 3.8.5 #22707

Closed
wants to merge 6 commits into from
Closed

worker: init at 3.8.5 #22707

wants to merge 6 commits into from

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Feb 12, 2017

Motivation for this change

Add worker file manager to Nixpkgs

Things done
  • [ x ] Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • Linux
  • [ x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • [ x] Fits CONTRIBUTING.md.

@ndowens ndowens mentioned this pull request Feb 12, 2017
2 tasks
@thufschmitt
Copy link
Member

You didn't include the package in all-packages.nix, so it won't be referenced anywhere. I assume this isn't intentional

@thufschmitt
Copy link
Member

(oh, and you probably should squash your commits into one)

@ndowens ndowens closed this Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants