Added worker to nixpkgs #22704
Closed
Added worker to nixpkgs #22704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 12, 2017
| { stdenv, fetchurl }: | ||
| let | ||
| pkgs = import <nixos> {}; | ||
| in |
There was a problem hiding this comment.
Please remove the line pkgs = import <nixos> {}; and import xorg in the first line:
{ stdenv, fetchurl, xorg }:
Mic92
reviewed
Feb 12, 2017
| let | ||
| pkgs = import <nixos> {}; | ||
| in | ||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Can you indent each line by two spaces, whenever a new brace is opened:
stdenv.mkDerivation rec {
name = "worker;
# ...
src = fetchurl {
url = "http://www.boomerangsworld.de/cms/worker/downloads/${name}-${version}.tar.gz";
# ...
Mic92
reviewed
Feb 12, 2017
| meta = with stdenv.lib; { | ||
| homepage = "http://www.boomerangsworld.de/cms/worker/index.html"; | ||
| description = "A two-pane file manager with advanced file manipulation features"; | ||
| license = licenses.gpl2; |
There was a problem hiding this comment.
Do you want to maintain this package?
|
Can you remove the other commits, where you added and removed |
|
How do I remove the commits I am still new to get
…Sent from my iphone
On Feb 12, 2017, 11:08 AM -0600, Jörg Thalheim ***@***.***>, wrote:
Can you remove the other commits, where you added and removed e3editor and retext?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (#22704 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL75NNsDdB3SWQFbtQRl4OTQ3sf7y0ks5rbzyZgaJpZM4L-hk7).
|
|
Sorry had to redo the package, I looked up how to remove commits and I did it, in which removed my package but am reuploading. It is now at #22707 Sorry for the trouble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)