mpd: fix on i686 #22717
mpd: fix on i686 #22717
Conversation
Was submtitted to upstream, but fix here in the meantime.
|
@Profpatsch, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @astsmtl and @rickynils to be potential reviewers. |
|
|
||
| -#include "lib/ffmpeg/Time.hxx" | ||
| #include "config.h" | ||
| +#include "lib/ffmpeg/Time.hxx" |
There was a problem hiding this comment.
Does it seem strange to you that this patch fixes it?
There was a problem hiding this comment.
Actually not, C/C++ headers are broken by design.
There was a problem hiding this comment.
No, their imports are order-dependent. That is, on i686 systems the software will not work correctly if config.h is not imported first. That is checked by a file check.h, and only if it’s a non-release build and it’s compiled for i686.
I point you to the thread at http://mailman.blarg.de/pipermail/mpd-devel/2017-February/000601.html for further incompetence.
There was a problem hiding this comment.
I’m kind of done with mpd by now, I just stream stuff to a pulseaudio sink. No idea why I thought setting one up again was a good idea. Certainly a waste of time …
| @@ -39,6 +39,8 @@ in stdenv.mkDerivation rec { | |||
| sha256 = "0a4psqsf71vc6hfgyv55jclsx8yb7lf4w840qlq6cq8j3hsjaavi"; | |||
| }; | |||
|
|
|||
| patches = [ ./i386.patch ]; | |||
There was a problem hiding this comment.
Can you add a comment, that this can be probably removed in the next release?
There was a problem hiding this comment.
Merged because the patch will fail to apply saying it was already applied.
Was submitted to upstream, but fix here in the meantime.