Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sessions with sddm. #22723

Merged
merged 1 commit into from Feb 13, 2017
Merged

Fix sessions with sddm. #22723

merged 1 commit into from Feb 13, 2017

Conversation

benley
Copy link
Member

@benley benley commented Feb 12, 2017

Motivation for this change

From email:

The sddm must be handled separately (as with kdm) in the xsession start
script because it treats the Exec line in the .desktop file as a
parameter and not a command, and due to the in the current master
branch sddm cannot start a session. The attached patch fixes this.

@mention-bot
Copy link

@benley, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nbp and @vcunat to be potential reviewers.

@grahamc
Copy link
Member

grahamc commented Feb 13, 2017

Oops :) I guess that comment applied to SDDM and KDM! Thank you for restoring it!

@grahamc grahamc merged commit 84d4e42 into NixOS:master Feb 13, 2017
@Zimmi48
Copy link
Member

Zimmi48 commented Feb 21, 2017

Does this fix #21353? If yes, does it make sense to merge this in 16.09? Sorry for the somewhat naive question.

@vcunat
Copy link
Member

vcunat commented Feb 21, 2017

@Zimmi48: no, this just restores the line that was only touched on master during KDE 4 removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants