Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epic5: init at 2.0.1 #22730

Merged
merged 2 commits into from
Feb 13, 2017
Merged

epic5: init at 2.0.1 #22730

merged 2 commits into from
Feb 13, 2017

Conversation

ndowens
Copy link

@ndowens ndowens commented Feb 13, 2017

Motivation for this change

Add Epic5 to nixpkg repo

Things done
  • [ x] Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • Linux
  • [x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • [x ] Fits CONTRIBUTING.md.

@vrthra vrthra added 0.kind: enhancement Add something new 8.has: package (new) This PR adds a new package labels Feb 13, 2017
@ndowens
Copy link
Author

ndowens commented Feb 13, 2017

@LnL7

LnL7
LnL7 reviewed Feb 13, 2017
View reviewed changes
pkgs/applications/networking/irc/epic5/default.nix Outdated
# Darwin needs libiconv, tcl; while Linux build don't

buildInputs = [ openssl ncurses ]
++ stdenv.lib.optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it works, it's preferred not to have nested lists in buildInputs. You can use stdenv.lib.optionals to add a list of conditional inputs.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

ndowens and others added 2 commits February 13, 2017 15:53
epic5: init at 2.0.1
dda70d9 
Added conditional to support darwin

Changed comment about buildInputs

Added 's' to optional condition
@LnL7
epic5: add configure flags
66eba1f
@LnL7
Copy link
Member

LnL7 commented Feb 13, 2017

I'm not sure why the binary segfaults on darwin. I did find these configure flags when looking at the homebrew definition, perhaps you should include them. https://gist.github.com/LnL7/705c5800e52be9a0fac397b90a34893a#file-epic5-patch-L36

@LnL7 LnL7 merged commit b165de3 into NixOS:master Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7

Assignees
No one assigned
Labels
0.kind: enhancement Add something new 8.has: package (new) This PR adds a new package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndowens @LnL7 @vrthra