libvirt: Fix #584 #598
Closed
libvirt: Fix #584 #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd say, please write a commit message that explains what this does (the PR cover message is good -- but that's not what enters the git repo) and someone with commit access please merge. (I too wondered why the image had perms 666 today...) |
See NixOS#598 for details.
|
Done, I think this can be merged now. |
|
Commited in 1266cdc |
AmineChikhaoui
pushed a commit
to nix-community/nixops-libvirtd
that referenced
this pull request
Jul 21, 2019
AmineChikhaoui
pushed a commit
to nix-community/nixops-libvirtd
that referenced
this pull request
Jul 21, 2019
AmineChikhaoui
pushed a commit
to nix-community/nixops-libvirtd
that referenced
this pull request
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the libvirt images readable only by their owner/group (i.e. the user/group under which is run qemu, by default root/root on NixOS afaik). It fixes a critical vulnerability in the libvirt backend.
The user does not actually need read/write permissions on that file for nixops to run correctly. If they want access to that file for other reasons, they should configure their libvirt installation to manage permissions accordingly (see e.g. https://libvirt.org/drvqemu.html#securitydac).