Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pythonPackages.pep257 #22325

Merged
merged 2 commits into from Feb 3, 2017
Merged

update pythonPackages.pep257 #22325

merged 2 commits into from Feb 3, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Jan 31, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@lsix, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

license = licenses.mit;
};
};
pytestpep257 = callPackage ../development/python-modules/pytestpep257.nix { };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its called pytest-pep257, let's rename it.
https://pypi.org/project/pytest-pep257/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@FRidh
Copy link
Member

FRidh commented Feb 1, 2017

also the filename?

@lsix
Copy link
Member Author

lsix commented Feb 1, 2017

done.

@FRidh FRidh merged commit e3f7104 into NixOS:master Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants