Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: 0.20.5 -> 0.21.0 #23079

Merged
merged 1 commit into from
Feb 27, 2017
Merged

crystal: 0.20.5 -> 0.21.0 #23079

merged 1 commit into from
Feb 27, 2017

Conversation

sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Feb 22, 2017 •
edited by LnL7

Motivation for this change

Update the package.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 mentioned this pull request Feb 24, 2017
Closed
7 tasks
@LnL7
Copy link
Member

LnL7 commented Feb 24, 2017

The linux build fails for me, not sure what's going wrong https://gist.github.com/LnL7/5a7dcf71e9eb6714c15baf37a7e2892a

@sifmelcara
Copy link
Member Author

sifmelcara commented Feb 25, 2017 •
edited

PR updated to rebase against NixOS/master.
@LnL7 Looks like your build failure is caused by insufficient memory, since crystal need ~5GB memory to build(at least for me), could you try again and see if it is caused by insufficient memory? thank you!

@LnL7
Copy link
Member

LnL7 commented Feb 25, 2017

I have tried to build it a bunch of times and even rebooted once. My build machine has 32G so I would be surprised if it's actually running out of memory.

@LnL7
Copy link
Member

LnL7 commented Feb 25, 2017

I got it to pass now, but I'm not sure how stable this will be on hydra.

@sifmelcara
Copy link
Member Author

Unfortunately I cannot reproduce the issue, I will report to upstream if I find a machine which can reproduce this issue.

@Mic92
Copy link
Member

Mic92 commented Feb 27, 2017 •
edited

I can build crystal with 12GB of RAM, while still running desktop applications like chrome. I have also a swap configured, but it was not really used.

@LnL7
Copy link
Member

LnL7 commented Feb 27, 2017

I don't have any swap configured, but I've never had issues before including a previous version of crystal.
Either way this is not really an issue if it builds fine on hydra.

@LnL7 LnL7 merged commit 4e88f77 into NixOS:master Feb 27, 2017
@sifmelcara sifmelcara mentioned this pull request Feb 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sifmelcara @LnL7 @Mic92