aenum: Init at 1.4.7 #22748
Merged
aenum: Init at 1.4.7 #22748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Feb 14, 2017
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchPypi { | ||
| inherit pname version; |
There was a problem hiding this comment.
does fetchPypi take pname? Should this buildPythonPackage call be embedded directly in python-packages.nix?
There was a problem hiding this comment.
fetchPypi (defined in pkgs/top-level/python-packages.nix) takes pname and version. Do you mean, put the expression in pkgs/top-level/python-packages.nix? I was asked earlier to put the new expressions in python-modules
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)