postfix service: don't empty local_recipient_maps #22431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peti
approved these changes
Feb 5, 2017
There was a problem hiding this comment.
IMHO, it's perfectly okay to merge that change. Most mail servers use virtual aliases for their users anyway, i.e. the host's local name is typically not equal to the domain name, and in that case this change in behavior will not affect people anyway. That's the case on my server, at least.
I don't think we should back-port the change to release-16.09 though.
I would like see an entry added to nixos/doc/manual/release-notes/rl-1703.xml, however, to make sure users updating from one release to the next are aware of this modification.
From Postfix documentation: With this setting, the Postfix SMTP server will not reject mail with "User unknown in local recipient table". Don't do this on systems that receive mail directly from the Internet. With today's worms and viruses, Postfix will become a backscatter source: it accepts mail for non-existent recipients and then tries to return that mail as "undeliverable" to the often forged sender address.
abbradar
force-pushed
the
postfix-local
branch
from
a1c34d8
to
52c7e64
Compare
|
I agree that this shouldn't be backported as this is a breaking change. Added an entry to the changelog. |
fpletz
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
From Postfix documentation:
However, I'm unsure that this is a right fix to do for everyone. Postfix can be configured in a multitude of ways: usually on my servers I set
local_recipient_mapsto a table with users, but perhaps for some other configurations this is not necessary.Also this is a breaking change, but one that gives us more secure defaults.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)