Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wget: 1.18 -> 1.19 #22416

Merged
merged 1 commit into from
Feb 5, 2017
Merged

wget: 1.18 -> 1.19 #22416

merged 1 commit into from
Feb 5, 2017

Conversation

lsix
Copy link
Member

@lsix lsix commented Feb 3, 2017

See http://lists.gnu.org/archive/html/info-gnu/2017-02/msg00000.html
for release announcement.

kiwix fails to build both before and after this commit.

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat vcunat self-assigned this Feb 5, 2017
@vcunat vcunat merged commit 77b72ae into NixOS:master Feb 5, 2017
vcunat added a commit that referenced this pull request Feb 5, 2017
@vcunat
Copy link
Member

vcunat commented Feb 5, 2017

I merged, but now I see this destroyed IDN support. It would now require a different version of libidn, and we don't have that in nixpkgs yet.

Also /cc maintainer @fpletz. BTW, libpsl isn't detected for some reason, and there are some other libs we might like to use (zlib, pcre, uuid).

@fpletz
Copy link
Member

fpletz commented Feb 6, 2017

libpsl was disabled in 9e38b81. IMHO it's okay to keep it disabled by default because it would only be needed this in rare cases.

Regarding the other libraries, I agree that we should add them as they should be useful and are probably in the system closure anyway. I adopted the package a while ago because not maintainer was listed but never got around overhauling the expression.

I've put it on my todo-list and would also package libidn2 if no one beats me before 17.03 is branched off. Thanks for mentioning me.

@fpletz
Copy link
Member

fpletz commented Feb 6, 2017

Ok, did it. ;)

fpletz added a commit that referenced this pull request Feb 6, 2017
wget now needs libidn2 instead of libidn.

cc #22416
fpletz added a commit that referenced this pull request Feb 6, 2017
@vcunat
Copy link
Member

vcunat commented Feb 6, 2017

Oh, I didn't notice that libpsl = null part :-)

libidn2 won't be in closure typically, but it might be useful to some and its closure isn't too big. (I guess IDNs are common e.g. in CJK countries.)

@7c6f434c
Copy link
Member

7c6f434c commented Feb 6, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants