Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumblebee service: Fix type error when pmMethod = "bbswitch" #22429

Merged
merged 1 commit into from
Feb 4, 2017

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Feb 4, 2017

Motivation for this change

nixos-rebuild switch was broken in nixos-unstable when hardware.bumblebee.pmMethod = "bbswitch";

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@srhb, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @ktosiek and @paraseba to be potential reviewers.

@abbradar abbradar merged commit d7bc733 into NixOS:master Feb 4, 2017
@abbradar
Copy link
Member

abbradar commented Feb 4, 2017

Thanks! Strange that it worked for me without this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants