default nixos config: add firewall options. #22336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@layus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @aszlig and @wkennington to be potential reviewers. |
edolstra
reviewed
Feb 1, 2017
| @@ -588,6 +588,12 @@ sub multiLineList { | |||
| # Enable the OpenSSH daemon. | |||
| # services.openssh.enable = true; | |||
|
|
|||
| # Open ports in the firewall | |||
edolstra
reviewed
Feb 1, 2017
| # Open ports in the firewall | ||
| # networking.firewall.allowedTCPPorts = [ ... ]; | ||
| # networking.firewall.allowedUDPPorts = [ ... ]; | ||
| # Or disable the firewall altogether |
By showing how to open ports in the firewall and how to disable it, we make users aware that there is a firewall enabled by default.
layus
force-pushed
the
nixos-firewall-config
branch
from
fc7381d
to
f81000d
Compare
|
@edolstra Updated according to comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By showing how to open ports in the firewall and how to disable it, we make users aware that there is a firewall enabled by default.
This implements the idea behind #12957 (as outlined by #12957 (comment)), without changing the default value.