Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heroku: fix runtime behavior #22338

Closed
wants to merge 2 commits into from
Closed

heroku: fix runtime behavior #22338

wants to merge 2 commits into from

Conversation

rasendubi
Copy link
Member

Motivation for this change

The new wrapper for heroku did not pass any command line arguments in, so heroku was useless. This commit fixes it.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@rasendubi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aflatter and @peterhoeg to be potential reviewers.

@rasendubi
Copy link
Member Author

pg:psql did not work as it expects psql on the local machine and the wrapper did not find it.

heroku pg:psql --app blah
---> Connecting to DATABASE_URL
sh: psql: command not found

Added a commit that includes psql in the env.

@rasendubi rasendubi mentioned this pull request Feb 1, 2017
Closed
@rasendubi rasendubi changed the title heroku: pass command line arguments in heroku: fix runtime behavior Feb 1, 2017
@rasendubi
Copy link
Member Author

Closed in favor of #22341.

@rasendubi rasendubi closed this Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rasendubi @mention-bot